Skip to content

Conversation

sjmonson
Copy link
Collaborator

Summary

Final pieces needed for image CI work. Fully enables auto latest, stable tags and old image pruning.

Details

  • Add pipefail to list-tags command to catch failures
  • Add missing ghcr.io/ to skopeo commands
  • Disable dry-run option for development image cleanup job

Test Plan

Ran with workflow_dispatch see here

2025-09-29T15-45-39 2025-09-29T15-46-02
  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Samuel Monson <[email protected]>
@sjmonson sjmonson requested a review from Copilot September 29, 2025 19:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes CI issues in the container maintenance workflow by adding proper error handling, correcting registry URLs, and enabling automatic cleanup of old development images.

  • Adds pipefail to catch command failures in the tag listing process
  • Fixes missing ghcr.io/ prefix in skopeo commands for proper registry authentication
  • Enables automatic cleanup by disabling dry-run mode for the image retention policy

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sjmonson sjmonson requested a review from markurtz September 29, 2025 20:00
@sjmonson sjmonson merged commit f8f6f9d into main Sep 30, 2025
19 checks passed
@sjmonson sjmonson deleted the feat/container_ci_debug branch September 30, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants